[ML] Data Visualizer redesign by darnautov · Pull Request #54358 · elastic/kibana

darnautov · 2020-01-09T15:47:49Z

Summary

Resolves #54114. Updated layout of the Data visualizer page.

Checklist

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2020-01-09T15:47:52Z

Pinging @elastic/ml-ui (:ml)

peteharverson · 2020-01-13T12:39:43Z

Are we handling cards for fields which don't appear in docs correctly? Managed to get to this (nginx_logs data, with time range set to one in which there are no docs. 9 fields, of which we are showing only card):

darnautov · 2020-01-13T14:43:09Z

Are we handling cards for fields which don't appear in docs correctly? Managed to get to this (nginx_logs data, with time range set to one in which there are no docs. 9 fields, of which we are showing only card):

Fixed in 9464c0a

…ualizer-redesign

mdefazio · 2020-01-14T16:44:37Z

+                <EuiBadge title="">
                  <b>{fieldVisConfigs.length}</b>
                </EuiBadge>


Is there a reason we added the title prop in?
And can we remove the <b> tag. Let's stick to the default weight in the EuiBadge.

the badge is wrapped with a tooltip, so we decided there is no need in the title (by default it's a content of the badge)

peteharverson

Tested latest edits and LGTM!

We should fix this console error in a follow-up, which I am guessing are caused by the changes in
#52987. All works ok, but would be good to remove the error.

…ualizer-redesign # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

jgowdyelastic

LGTM

kibanamachine · 2020-01-14T18:46:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ad5cad9

History

💚 Build #20222 succeeded 0c9eeb8
💚 Build #20193 succeeded e30ab8c
💚 Build #20164 succeeded a153039
💚 Build #19964 succeeded 2889e18
💚 Build #19766 succeeded 9464c0a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * Update styling of panels, spacing * [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * [ML] fix i18n * [ML] fix styles * [ML] adjust top values styles * [ML] remove conflicts artifacts * Use EuiBorderColor * [ML] fix i18n * [ML] fix i18n * [ML] fix counters * [ML] fixed width for sample size select * [ML] fix layout for file viz * [ML] fix empty cards rendering * Update text styling and spacing * [ML] fix field stats card * [ML] fix counter for showAllFields * [ML] reset title for the badge * [ML] boolean_content.tsx with the bar chart * [ML] fix counters Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * Update styling of panels, spacing * [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * [ML] fix i18n * [ML] fix styles * [ML] adjust top values styles * [ML] remove conflicts artifacts * Use EuiBorderColor * [ML] fix i18n * [ML] fix i18n * [ML] fix counters * [ML] fixed width for sample size select * [ML] fix layout for file viz * [ML] fix empty cards rendering * Update text styling and spacing * [ML] fix field stats card * [ML] fix counter for showAllFields * [ML] reset title for the badge * [ML] boolean_content.tsx with the bar chart * [ML] fix counters Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * Update styling of panels, spacing * [ML] change basic page structure * [ML] adjust search panel * [ML] adjust fields_panel.tsx * [ML] card icon styles * [ML] styles * [ML] adjust actions_panel.tsx * [ML] fix i18n * [ML] fix styles * [ML] adjust top values styles * [ML] remove conflicts artifacts * Use EuiBorderColor * [ML] fix i18n * [ML] fix i18n * [ML] fix counters * [ML] fixed width for sample size select * [ML] fix layout for file viz * [ML] fix empty cards rendering * Update text styling and spacing * [ML] fix field stats card * [ML] fix counter for showAllFields * [ML] reset title for the badge * [ML] boolean_content.tsx with the bar chart * [ML] fix counters Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

darnautov added 6 commits January 9, 2020 11:55

[ML] change basic page structure

1884908

[ML] adjust search panel

1909d38

[ML] adjust fields_panel.tsx

fdbfc06

[ML] card icon styles

54c0316

[ML] styles

d26af58

[ML] adjust actions_panel.tsx

94fef77

darnautov added release_note:enhancement :ml v8.0.0 v7.6.0 labels Jan 9, 2020

darnautov requested review from jgowdyelastic, mdefazio and peteharverson January 9, 2020 15:47

darnautov requested review from a team as code owners January 9, 2020 15:47

darnautov self-assigned this Jan 9, 2020

mdefazio and others added 9 commits January 9, 2020 16:30

Update styling of panels, spacing

85fb81c

[ML] change basic page structure

38aa5af

[ML] adjust search panel

d09adcd

[ML] adjust fields_panel.tsx

96f5df7

[ML] card icon styles

f7db66f

[ML] styles

efc3fb1

[ML] adjust actions_panel.tsx

7dc4bcb

[ML] fix i18n

9d07f44

[ML] fix styles

f182c87

darnautov force-pushed the ML-54114-data-visualizer-redesign branch from eedbbc2 to f182c87 Compare January 10, 2020 11:26

darnautov and others added 3 commits January 10, 2020 12:29

[ML] adjust top values styles

0c00ae3

Merge origin, fix conflicts

d518a90

[ML] remove conflicts artifacts

c0c53cd

peteharverson reviewed Jan 13, 2020

View reviewed changes

Comment thread ...tion/datavisualizer/index_based/components/field_data_card/content_types/keyword_content.tsx Outdated

peteharverson reviewed Jan 13, 2020

View reviewed changes

Comment thread ...ns/ml/public/application/datavisualizer/index_based/components/search_panel/search_panel.tsx

peteharverson reviewed Jan 13, 2020

View reviewed changes

Comment thread ...ation/datavisualizer/index_based/components/field_data_card/content_types/number_content.tsx

peteharverson reviewed Jan 13, 2020

View reviewed changes

Comment thread ...blic/application/datavisualizer/index_based/components/field_data_card/_field_data_card.scss

darnautov added 4 commits January 13, 2020 14:07

[ML] fix counters

5a39b62

[ML] fixed width for sample size select

5be2ae4

[ML] fix layout for file viz

35f4033

[ML] fix empty cards rendering

9464c0a

mdefazio and others added 2 commits January 13, 2020 15:58

Update text styling and spacing

2889e18

Merge remote-tracking branch 'upstream/master' into ML-54114-data-vis…

7e4a53a

…ualizer-redesign

peteharverson reviewed Jan 14, 2020

View reviewed changes

Comment thread x-pack/legacy/plugins/ml/public/application/datavisualizer/index_based/page.tsx

darnautov added 5 commits January 14, 2020 13:47

Merge remote-tracking branch 'upstream/master' into ML-54114-data-vis…

b595235

…ualizer-redesign

[ML] fix field stats card

34ddc1f

[ML] fix counter for showAllFields

c16861c

[ML] reset title for the badge

a153039

[ML] boolean_content.tsx with the bar chart

e30ab8c

mdefazio reviewed Jan 14, 2020

View reviewed changes

[ML] fix counters

0c9eeb8

peteharverson approved these changes Jan 14, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into ML-54114-data-vis…

ad5cad9

…ualizer-redesign # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

jgowdyelastic approved these changes Jan 14, 2020

View reviewed changes

darnautov merged commit 1b07617 into elastic:master Jan 14, 2020

darnautov deleted the ML-54114-data-visualizer-redesign branch January 14, 2020 18:53

darnautov mentioned this pull request Jan 14, 2020

[7.x] [ML] Data Visualizer redesign (#54358) #54787

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Data Visualizer redesign#54358

[ML] Data Visualizer redesign#54358
darnautov merged 36 commits intoelastic:masterfrom
darnautov:ML-54114-data-visualizer-redesign

darnautov commented Jan 9, 2020

Uh oh!

elasticmachine commented Jan 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peteharverson commented Jan 13, 2020

Uh oh!

Uh oh!

darnautov commented Jan 13, 2020

Uh oh!

Uh oh!

mdefazio Jan 14, 2020

Uh oh!

darnautov Jan 14, 2020

Uh oh!

peteharverson left a comment

Uh oh!

jgowdyelastic left a comment

Uh oh!

kibanamachine commented Jan 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

darnautov commented Jan 9, 2020

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peteharverson commented Jan 13, 2020

Uh oh!

Uh oh!

darnautov commented Jan 13, 2020

Uh oh!

Uh oh!

mdefazio Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

darnautov Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 14, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants